Skip to content

chore: report result when action fails #10063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kizuna-lek wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: report result when action fails #10063

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a73170
chore: report result when action fails
kizuna-lek Feb 27, 2026
f0340ce
fix
kizuna-lek Mar 2, 2026
ee670af
fix
kizuna-lek Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions pkg/kbagent/service/action_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,17 +110,29 @@ func blockingCallAction(ctx context.Context, action *kbaproto.Action, parameters
err = result.err
if err != nil {
var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
stderrMsg := result.stderr.String()

switch {
case errors.As(err, &exitErr):
errMsg := fmt.Sprintf("exit code: %d", exitErr.ExitCode())
if stderrMsg := result.stderr.String(); len(stderrMsg) > 0 {
if len(stderrMsg) > 0 {
errMsg += fmt.Sprintf(", stderr: %s", stderrMsg)
}
return nil, errors.Wrapf(kbaproto.ErrFailed, "%s", errMsg)
case errors.Is(err, kbaproto.ErrTimedOut):
var errMsg string
if stdoutMsg := result.stdout.String(); len(stdoutMsg) > 0 {
errMsg = fmt.Sprintf("stdout: %s", stdoutMsg)
}
if len(stderrMsg) > 0 {
errMsg += fmt.Sprintf(", stderr: %s", stderrMsg)
}
return nil, errors.Wrapf(kbaproto.ErrTimedOut, "%s", errMsg)
case len(stderrMsg) > 0:
return nil, errors.Wrapf(err, "%s", stderrMsg)
default:
return nil, err
}
if errMsg := result.stderr.String(); len(errMsg) > 0 {
return nil, errors.Wrapf(err, "%s", errMsg)
}
return nil, err
}
return result.stdout.Bytes(), nil
}
Expand Down