Skip to content

fix: rebuild instance ops always is running for sharding component when inplace = false#10053

Merged
wangyelei merged 1 commit intomainfrom
bugfix/rebuild_instance_always_running
Feb 27, 2026
Merged

fix: rebuild instance ops always is running for sharding component when inplace = false#10053
wangyelei merged 1 commit intomainfrom
bugfix/rebuild_instance_always_running

Conversation

@wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested a review from a team as a code owner February 11, 2026 08:50
@wangyelei wangyelei added the pick-1.1 Auto cherry-pick to release-1.1 when PR merged label Feb 11, 2026
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.16%. Comparing base (804edc4) to head (3e7776c).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operations/rebuild_instance.go 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10053      +/-   ##
==========================================
+ Coverage   51.37%   52.16%   +0.79%     
==========================================
  Files         541      545       +4     
  Lines       58774    60461    +1687     
==========================================
+ Hits        30194    31541    +1347     
- Misses      25627    25916     +289     
- Partials     2953     3004      +51     
Flag Coverage Δ
unittests 52.16% <58.33%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 26, 2026
@wangyelei
Copy link
Contributor Author

/approved

@wangyelei wangyelei merged commit ea54720 into main Feb 27, 2026
50 of 51 checks passed
@wangyelei wangyelei deleted the bugfix/rebuild_instance_always_running branch February 27, 2026 02:52
@github-actions github-actions bot added this to the Release 1.2.0 milestone Feb 27, 2026
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.1

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/22470709348

apecloud-bot pushed a commit that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.1 Auto cherry-pick to release-1.1 when PR merged size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] RebuildInstance with inPlace=false not working on sharding clusters

3 participants