chore: expose more conditions in component status #10032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Auto Cherry-pick Instructions |
cjc7373
force-pushed
the
support/refactor-comp-status
branch
from
eae9b69 to
88b0496
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10032 +/- ##
==========================================
+ Coverage 51.26% 51.39% +0.12%
==========================================
Files 539 539
Lines 58727 58786 +59
==========================================
+ Hits 30108 30212 +104
+ Misses 25667 25629 -38
+ Partials 2952 2945 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cjc7373
commented
Feb 3, 2026
| // TODO: replicas == 0, stopped, updating, abnormal? | ||
| WithPhases: pointer.String(string(appsv1.RunningComponentPhase)), | ||
| WithPhases: pointer.String(strings.Join( | ||
| []string{string(appsv1.RunningComponentPhase), string(appsv1.UpdatingComponentPhase)}, |
Contributor
Author
There was a problem hiding this comment.
Updating is added as a default available phase, because any pod fail (such as a node down) can cause the phase to become Updating
cjc7373
force-pushed
the
support/refactor-comp-status
branch
from
a001419 to
8038a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current component condition provides very little information about why the component is not healthy.