Skip to content

feat(apis): enhance API for config manager migration to kbagent #10016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leon-ape merged 3 commits into from
Jan 23, 2026
Merged

feat(apis): enhance API for config manager migration to kbagent #10016

leon-ape merged 3 commits into from
Jan 23, 2026

Conversation

@leon-ape
Copy link
Contributor

@leon-ape leon-ape commented Jan 22, 2026

  • Add Reconfigure field to ComponentFileTemplate
  • Reorganize ClusterComponentConfig fields
  • Add ConfigHash and RestartOnConfigChange fields
  • Update ReloadPolicy enum (remove rolling)
  • Fix GetComponentByName method to return pointer to slice element

@apecloud-bot
Copy link
Collaborator

apecloud-bot commented Jan 22, 2026

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 22, 2026
@leon-ape
Copy link
Contributor Author

leon-ape commented Jan 22, 2026

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Jan 22, 2026
@leon-ape @claude
feat(apis): enhance API for config manager migration to kbagent
9ce6275 
- Add Reconfigure field to ComponentFileTemplate
- Reorganize ClusterComponentConfig fields
- Add ConfigHash and RestartOnConfigChange fields
- Update ReloadPolicy enum (remove rolling)
- Fix GetComponentByName method to return pointer to slice element

Co-Authored-By: Claude <[email protected]>
@leon-ape leon-ape force-pushed the feature/config-manager-migration-phase1-api branch from c8a2fc8 to 9ce6275 Compare January 22, 2026 07:28
@leon-ape leon-ape marked this pull request as ready for review January 22, 2026 07:34
@leon-ape leon-ape requested a review from a team as a code owner January 22, 2026 07:34
@leon-ape leon-ape requested a review from kizuna-lek January 22, 2026 07:34
@codecov
Copy link

codecov bot commented Jan 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.43%. Comparing base (6ad4438) to head (c277816).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apis/apps/v1/deprecated.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10016      +/-   ##
==========================================
+ Coverage   51.34%   51.43%   +0.08%     
==========================================
  Files         541      541              
  Lines       58770    58770              
==========================================
+ Hits        30175    30227      +52     
+ Misses      25637    25596      -41     
+ Partials     2958     2947      -11
Flag Coverage Δ
unittests 51.43% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape
Copy link
Contributor Author

leon-ape commented Jan 22, 2026

/nopick

@leon-ape leon-ape added this to the Release 1.2.0 milestone Jan 22, 2026
kizuna-lek
kizuna-lek reviewed Jan 23, 2026
View reviewed changes
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 23, 2026
@leon-ape leon-ape merged commit d5f8fb8 into main Jan 23, 2026
54 of 56 checks passed
@leon-ape leon-ape deleted the feature/config-manager-migration-phase1-api branch January 23, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjc7373 cjc7373 cjc7373 approved these changes

@kizuna-lek kizuna-lek kizuna-lek approved these changes

Assignees

No one assigned

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Milestone

Release 1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@leon-ape @apecloud-bot @cjc7373 @kizuna-lek