fix: prefer exact match for backup method env version mapping #10012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, version mapping used prefix/regex matching which could incorrectly match similar versions. This change adds a two-pass approach that first looks for an exact match before falling back to prefix/regex matching, ensuring more accurate version resolution.
shanshanying
requested review from
a team,
ldming and
wangyelei
as code owners
shanshanying
added
pick-1.0
Collaborator
|
Auto Cherry-pick Instructions |
wangyelei
approved these changes
Jan 21, 2026
ldming
approved these changes
Jan 21, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10012 +/- ##
==========================================
+ Coverage 51.41% 51.44% +0.02%
==========================================
Files 541 541
Lines 58763 58770 +7
==========================================
+ Hits 30215 30235 +20
+ Misses 25598 25575 -23
- Partials 2950 2960 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shanshanying
deleted the
bugfix/backup-policy-version-mapping-exact-match
branch
Collaborator
|
/cherry-pick release-1.1 |
Collaborator
|
/cherry-pick release-1.0 |
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Co-authored-by: wusai80 <[email protected]> (cherry picked from commit 2275dc0)
apecloud-bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Co-authored-by: wusai80 <[email protected]> (cherry picked from commit 2275dc0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, version mapping used prefix/regex matching which could incorrectly match similar versions. This change adds a two-pass approach that first looks for an exact match before falling back to prefix/regex matching, ensuring more accurate version resolution.