Skip to content

chore: update sentinel down-after-milliseconds option to 20000 #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangyelei merged 2 commits into from
Feb 10, 2026
Merged

chore: update sentinel down-after-milliseconds option to 20000 #2441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b1ce7
chore: update sentinel down-after-milliseconds option to 20000
wangyelei Feb 9, 2026
a8ba2ef
fix bug
wangyelei Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/redis/scripts-ut-spec/redis_register_to_sentinel_spec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ Describe 'register_to_sentinel.sh'
It 'constructs the sentinel down-after-milliseconds sub command correctly'
When call construct_sentinel_sub_command "down-after-milliseconds" "redis-redis" "redis-redis-0.redis-redis.default.svc.cluster.local" "6379"
The status should be success
The output should eq "SENTINEL set redis-redis down-after-milliseconds 5000"
The output should eq "SENTINEL set redis-redis down-after-milliseconds 20000"
End

It 'constructs the sentinel failover-timeout sub command correctly'
Expand Down Expand Up @@ -192,7 +192,7 @@ Describe 'register_to_sentinel.sh'
When call register_to_sentinel $sentinel_host $master_name $redis_primary_host $redis_primary_port
The status should be success
The output should include "host:redis-redis-sentinel-0.redis-redis-sentinel-headless.default.svc.cluster.local, port:26379 Command:SENTINEL monitor redis-redis redis-redis-0.redis-redis.default.svc.cluster.local 6379 2"
The output should include "host:redis-redis-sentinel-0.redis-redis-sentinel-headless.default.svc.cluster.local, port:26379 Command:SENTINEL set redis-redis down-after-milliseconds 5000 executed successfully."
The output should include "host:redis-redis-sentinel-0.redis-redis-sentinel-headless.default.svc.cluster.local, port:26379 Command:SENTINEL set redis-redis down-after-milliseconds 20000 executed successfully."
The output should include "host:redis-redis-sentinel-0.redis-redis-sentinel-headless.default.svc.cluster.local, port:26379 Command:SENTINEL set redis-redis failover-timeout 60000"
The output should include "host:redis-redis-sentinel-0.redis-redis-sentinel-headless.default.svc.cluster.local, port:26379 Command:SENTINEL set redis-redis parallel-syncs 1"
The output should include "host:redis-redis-sentinel-0.redis-redis-sentinel-headless.default.svc.cluster.local, port:26379 Command:SENTINEL set redis-redis auth-user"
Expand Down
12 changes: 6 additions & 6 deletions addons/redis/scripts-ut-spec/redis_sentinel_member_join_spec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Describe "Redis Sentinel Member Join Script Tests"
flags
master
down-after-milliseconds
5000
20000
quorum
2
failover-timeout
Expand All @@ -87,7 +87,7 @@ Describe "Redis Sentinel Member Join Script Tests"
The status should be success
The stdout should include "all masters are reachable"
The contents of file "$redis_sentinel_real_conf" should include "sentinel monitor mymaster 172.20.0.1 30746 2"
The contents of file "$redis_sentinel_real_conf" should include "sentinel down-after-milliseconds mymaster 5000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel down-after-milliseconds mymaster 20000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel failover-timeout mymaster 60000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel parallel-syncs mymaster 1"
The contents of file "$redis_sentinel_real_conf" should include "sentinel auth-user mymaster $REDIS_SENTINEL_USER"
Expand Down Expand Up @@ -138,7 +138,7 @@ Describe "Redis Sentinel Member Join Script Tests"
flags
master
down-after-milliseconds
5000
20000
quorum
2
failover-timeout
Expand All @@ -154,7 +154,7 @@ Describe "Redis Sentinel Member Join Script Tests"
flags
master
down-after-milliseconds
5000
20000
quorum
2
failover-timeout
Expand All @@ -166,13 +166,13 @@ Describe "Redis Sentinel Member Join Script Tests"
The status should be success
The stdout should include "all masters are reachable"
The contents of file "$redis_sentinel_real_conf" should include "sentinel monitor redis-redis0 172.20.0.1 30746 2"
The contents of file "$redis_sentinel_real_conf" should include "sentinel down-after-milliseconds redis-redis0 5000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel down-after-milliseconds redis-redis0 20000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel failover-timeout redis-redis0 60000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel parallel-syncs redis-redis0 1"
The contents of file "$redis_sentinel_real_conf" should include "sentinel auth-user redis-redis0 $REDIS_SENTINEL_USER"
The contents of file "$redis_sentinel_real_conf" should include "sentinel auth-pass redis-redis0 $REDIS_SENTINEL_PASSWORD_REDIS0"
The contents of file "$redis_sentinel_real_conf" should include "sentinel monitor redis-redis1 172.20.0.2 30747 2"
The contents of file "$redis_sentinel_real_conf" should include "sentinel down-after-milliseconds redis-redis1 5000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel down-after-milliseconds redis-redis1 20000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel failover-timeout redis-redis1 60000"
The contents of file "$redis_sentinel_real_conf" should include "sentinel parallel-syncs redis-redis1 1"
The contents of file "$redis_sentinel_real_conf" should include "sentinel auth-user redis-redis1 $REDIS_SENTINEL_USER"
Expand Down
2 changes: 1 addition & 1 deletion addons/redis/scripts/redis-register-to-sentinel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ construct_sentinel_sub_command() {
echo "SENTINEL monitor $master_name $redis_primary_host $redis_primary_port 2"
;;
"down-after-milliseconds")
echo "SENTINEL set $master_name down-after-milliseconds 5000"
echo "SENTINEL set $master_name down-after-milliseconds 20000"
;;
"failover-timeout")
echo "SENTINEL set $master_name failover-timeout 60000"
Expand Down