fix: preserve schemaProperties in SinkConfigUtils inputSpecs round-trip - #26426
Open
waterWang wants to merge 1 commit into
Open
fix: preserve schemaProperties in SinkConfigUtils inputSpecs round-trip#26426waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…ip (apache#26425) SinkConfigUtils.convert() and convertFromDetails() both silently drop schemaProperties from ConsumerSpec when building inputSpecs, while FunctionConfigUtils handles the field correctly. This causes permanent drift for declarative tooling (e.g. Terraform providers) that set schemaProperties on a sink input spec. The proto field (ConsumerSpec.schemaProperties = 5) and the model (ConsumerConfig.schemaProperties) both exist; only the SinkConfigUtils conversion paths omit it. Fix: copy schemaProperties in both directions, mirroring the existing consumerProperties handling, and add round-trip coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26425
Added
schemaPropertiescopy in bothconvert()andconvertFromDetails()inSinkConfigUtils, mirroring theconsumerPropertieshandling andFunctionConfigUtilsreference implementation.