Fix error example of multiple-advertised-listeners#1017
Fix error example of multiple-advertised-listeners#1017casuallc wants to merge 2 commits intoapache:mainfrom
Conversation
| // External client with SSL | ||
| PulsarClient externalClient = PulsarClient.builder() | ||
| .serviceUrl("pulsar+ssl://external-brokers.example.com:6651") | ||
| .serviceUrl("pulsar+ssl://external-brokers.example.com:16651") |
There was a problem hiding this comment.
This isn't actually a mistake. Earlier there's a sentence "Add a load balancer that proxies to any healthy available broker on the external listener port.". The load balancer (or rather a gateway) should map external-brokers.example.com:6651 to the internal IP address of the broker to port 16651. This should be clarified in the docs. Would you like to revisit this PR to cover that instead?
There was a problem hiding this comment.
One more addition:
If the external-brokers.example.com DNS name maps directly to the IP of the broker that it's bound to, then it should be port 16651, so there are 2 cases to cover.
There was a problem hiding this comment.
This isn't actually a mistake. Earlier there's a sentence "Add a load balancer that proxies to any healthy available broker on the external listener port.". The load balancer (or rather a gateway) should map external-brokers.example.com:6651 to the internal IP address of the broker to port 16651. This should be clarified in the docs. Would you like to revisit this PR to cover that instead?
If 6651 is proxed to 16651, the broker should response external-brokers.example.com:16651, then client wolud connected to external-brokers.example.com:16651？
|
@lhotari Ready to merge? |
3 participants
✅ Contribution Checklist