Fix nodeSelector and tolerations handling in dekaf-deployment.yaml#682
Merged
lhotari merged 3 commits intoapache:masterfrom May 4, 2026
Merged
Fix nodeSelector and tolerations handling in dekaf-deployment.yaml#682lhotari merged 3 commits intoapache:masterfrom
lhotari merged 3 commits intoapache:masterfrom
Conversation
Fix for the issue reported in here: apache#681
lhotari
requested changes
May 4, 2026
Member
lhotari
left a comment
There was a problem hiding this comment.
Fails with multiple nodeSelectors or tolerations:
helm template test ./charts/pulsar \
--set components.dekaf=true \
--set 'dekaf.deployment.nodeSelector.disk=ssd' \
--set 'dekaf.deployment.nodeSelector.zone=us-east-1' \
--set 'dekaf.deployment.nodeSelector.arch=amd64' \
--set 'dekaf.deployment.tolerations[0].key=foo' \
--set 'dekaf.deployment.tolerations[0].operator=Equal' \
--set 'dekaf.deployment.tolerations[0].value=bar' \
--set 'dekaf.deployment.tolerations[0].effect=NoSchedule' \
--set 'dekaf.deployment.tolerations[1].key=baz' \
--set 'dekaf.deployment.tolerations[1].operator=Exists' \
--set 'dekaf.deployment.tolerations[1].effect=NoExecute' \
--show-only templates/dekaf-deployment.yaml \
--debug
Claude Code suggested either one of these fixes:
Option 1, using indent:
nodeSelector:
{{ toYaml .Values.broker.nodeSelector | indent 8 }}
tolerations:
{{ toYaml .Values.broker.tolerations | indent 8 }}Option 2, using nindent:
nodeSelector:
{{- toYaml .Values.broker.nodeSelector | nindent 8 }}
tolerations:
{{- toYaml .Values.broker.tolerations | nindent 8 }}
1 task
Replaced indent value changes and applied indentations to both lines instead.
lhotari
reviewed
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the Dekaf UI issue reported in here: #681
Fixes: #681
Motivation
Rendering of the
dekaf-deployment.yamltemplate fails whenValues.dekaf.deployment.nodeSelectorandValues.dekaf.deployment.tolerationsare true.Modifications
This PR adjusts the indentations configured in lines 48 and 53
Verifying this change