Skip to content

Fix nodeSelector and tolerations handling in dekaf-deployment.yaml#682

Merged
lhotari merged 3 commits intoapache:masterfrom
jvellaft:patch-1
May 4, 2026
Merged

Fix nodeSelector and tolerations handling in dekaf-deployment.yaml#682
lhotari merged 3 commits intoapache:masterfrom
jvellaft:patch-1

Conversation

@jvellaft
Copy link
Copy Markdown
Contributor

@jvellaft jvellaft commented May 4, 2026

Fix for the Dekaf UI issue reported in here: #681

Fixes: #681

Motivation

Rendering of the dekaf-deployment.yaml template fails when Values.dekaf.deployment.nodeSelector and Values.dekaf.deployment.tolerations are true.

Error: INSTALLATION FAILED: YAML parse error on pulsar/templates/dekaf-deployment.yaml: error converting YAML to JSON: yaml: line 55: did not find expected key
helm.go:92: 2026-05-04 11:04:33.581691 +0200 CEST m=+1.425366083 [debug] error converting YAML to JSON: yaml: line 55: did not find expected key
YAML parse error on pulsar/templates/dekaf-deployment.yaml

Modifications

This PR adjusts the indentations configured in lines 48 and 53

Verifying this change

  • Make sure that the change passes the CI checks.

Fix for the issue reported in here: apache#681
Copy link
Copy Markdown
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with multiple nodeSelectors or tolerations:

  helm template test ./charts/pulsar \
    --set components.dekaf=true \
    --set 'dekaf.deployment.nodeSelector.disk=ssd' \
    --set 'dekaf.deployment.nodeSelector.zone=us-east-1' \
    --set 'dekaf.deployment.nodeSelector.arch=amd64' \
    --set 'dekaf.deployment.tolerations[0].key=foo' \
    --set 'dekaf.deployment.tolerations[0].operator=Equal' \
    --set 'dekaf.deployment.tolerations[0].value=bar' \
    --set 'dekaf.deployment.tolerations[0].effect=NoSchedule' \
    --set 'dekaf.deployment.tolerations[1].key=baz' \
    --set 'dekaf.deployment.tolerations[1].operator=Exists' \
    --set 'dekaf.deployment.tolerations[1].effect=NoExecute' \
    --show-only templates/dekaf-deployment.yaml \
    --debug    

Claude Code suggested either one of these fixes:

Option 1, using indent:

      nodeSelector:
{{ toYaml .Values.broker.nodeSelector | indent 8 }}
      tolerations:
{{ toYaml .Values.broker.tolerations | indent 8 }}

Option 2, using nindent:

      nodeSelector:
        {{- toYaml .Values.broker.nodeSelector | nindent 8 }}
      tolerations:
        {{- toYaml .Values.broker.tolerations | nindent 8 }}

@lhotari lhotari changed the title Update dekaf-deployment.yaml Fix nodeSelector and tolerations handling in dekaf-deployment.yaml May 4, 2026
Replaced indent value changes and applied indentations to both lines instead.
@jvellaft jvellaft requested a review from lhotari May 4, 2026 11:12
Comment thread charts/pulsar/templates/dekaf-deployment.yaml Outdated
Copy link
Copy Markdown
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 8d69259 into apache:master May 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rendering of the pulsar-manager-cluster-initialize.yaml template fails

2 participants