fix: Improve Zookeeper initialization wait logic to support multi url configuration store#671
Merged
lhotari merged 5 commits intoapache:masterfrom Apr 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Pulsar Helm chart’s cluster-initialization Job to wait for a multi-URL ZooKeeper configuration store using a ZooKeeper-aware command instead of DNS lookup, addressing init failures when configurationStore contains comma-separated hosts.
Changes:
- Replace
nslookup-based waiting forconfigurationStorewithbin/pulsar zookeeper-shell ... ls /polling. - Set a smaller JVM heap (
PULSAR_MEM) for the wait probe to reduce init-container memory usage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
please check copilot's review comments |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@lhotari addressed both the comments. also, assumed that configuration store deployment uses the same tls settings as zookeeper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #670
Motivation
When using a multi-URL configuration store (e.g., zk1:2181,zk2:2181), the wait-zk-cs-ready init container fails because nslookup cannot resolve comma-separated hostnames. This causes initialization to time out even when ZooKeeper is already accessible.
Modifications
Replaced nslookup with bin/pulsar zookeeper-shell -server ls /, which supports the full ZooKeeper connection string including multi-URL formats.
Verifying this change