Allow dynamic toggling of adaptive routing metrics export#18286
Open
timothy-e wants to merge 3 commits intoapache:masterfrom
Open
Allow dynamic toggling of adaptive routing metrics export#18286timothy-e wants to merge 3 commits intoapache:masterfrom
timothy-e wants to merge 3 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18286 +/- ##
============================================
+ Coverage 63.60% 63.61% +0.01%
Complexity 1659 1659
============================================
Files 3246 3246
Lines 197510 197554 +44
Branches 30578 30585 +7
============================================
+ Hits 125620 125671 +51
+ Misses 61845 61836 -9
- Partials 10045 10047 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@xiangfu0 @Jackie-Jiang @yashmayya can one of you take a look at this? |
xiangfu0
reviewed
Apr 23, 2026
Contributor
xiangfu0
left a comment
xiangfu0
left a comment
There was a problem hiding this comment.
Found one high-confidence concurrency issue in the dynamic metrics toggle.
Contributor
Author
|
@xiangfu0 thanks for catching that - can you take another look? |
Committed-By-Agent: claude cc stripe-private-oss-forks/pinot-reviewers r? https://git.corp.stripe.com/stripe-private-oss-forks/pinot/pull/581 added metrics for adaptive routing stats. We may want to toggle whether or not stats are exported as metrics without needing to launch a rolling restart. ServerRoutingStatsManager now implements PinotClusterConfigChangeListener. The periodic export task is always scheduled when stats collection is enabled; the enable.stats.metric.export flag is checked inside the task and can be updated at runtime via the Helix cluster config (PUT /cluster/configs) without a broker restart. We also allow updating the metrics export frequency at runtime. [STREAMANALYTICS-4390](https://jira.corp.stripe.com/browse/STREAMANALYTICS-4390) Deployed to [rad-canary QA](https://amp.qa.corp.stripe.com/deploy/qa-deploy1.pdx.deploy.stripe.net%2Fdeploy_r2WUckQcQ467TfeJvyp4zw). `ssh`ed onto a rad-canary controller and ran ``` curl -X POST localhost:9000/cluster/configs -H "Content-Type: application/json" -d '{"pinot.broker.adaptive.server.selector.enable.stats.metric.export": "false"}' curl -X POST localhost:9000/cluster/configs -H "Content-Type: application/json" -d '{"pinot.broker.adaptive.server.selector.enable.stats.metric.export": "true"}' curl -X POST localhost:9000/cluster/configs -H "Content-Type: application/json" -d '{"pinot.broker.adaptive.server.selector.enable.stats.metric.export": "false"}' ``` I see that the metrics stopped / resumed as expected in [grafana](https://g-8916660cfe.grafana-workspace.us-west-2.amazonaws.com/explore?schemaVersion=1&panes=%7B%223yy%22:%7B%22datasource%22:%22zb219lV4k%22,%22queries%22:%5B%7B%22refId%22:%22B%22,%22expr%22:%22count%20by%20%28host%29%20%28%7B__name__%3D~%5C%22pinot_broker_adaptive_server_latency_ema%5C%22,%20pinot_cluster%3D%5C%22rad-canary%5C%22%7D%29%22,%22range%22:true,%22instant%22:true,%22datasource%22:%7B%22type%22:%22prometheus%22,%22uid%22:%22zb219lV4k%22%7D,%22editorMode%22:%22code%22,%22legendFormat%22:%22__auto%22%7D%5D,%22range%22:%7B%22from%22:%221775159834995%22,%22to%22:%221775160734995%22%7D%7D%7D&orgId=1) <img width="1477" alt="Screenshot 2026-04-02 at 4 17 58 pm" src="https://git.corp.stripe.com/user-attachments/assets/dca06b6d-8b6f-4797-a079-95a1f21d7de7" /> Stripe-Original-Repo: stripe-private-oss-forks/pinot Stripe-Monotonic-Timestamp: v2/2026-04-07T21:12:57Z/0 Stripe-Original-PR: https://git.corp.stripe.com/stripe-private-oss-forks/pinot/pull/582
timothy-e
force-pushed
the
timothy-e-adaptive-routing-dynamic-toggle
branch
from
a9122af to
42877ef
Compare
xiangfu0
reviewed
Apr 24, 2026
Contributor
xiangfu0
left a comment
xiangfu0
left a comment
There was a problem hiding this comment.
Found one high-signal config-safety issue; see inline comment.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18134 adds metrics for adaptive routing stats.
We may want to toggle whether or not stats are exported as metrics without needing to rolling restart the brokers.
ServerRoutingStatsManager now implements PinotClusterConfigChangeListener. The periodic export task is always scheduled when stats collection is enabled; the enable.stats.metric.export flag is checked inside the task and can be updated at runtime via the Helix cluster config (PUT /cluster/configs) without a broker restart.
We also allow updating the metrics export frequency at runtime.
If the metric interval set to a bad value at startup, it'll block the cluster from starting. But if a bad value is set dynamically, if we don't validate it, it could stop us from reaching later listeners.
Testing
Deployed to an internal Stripe cluster.
sshed onto one of the controllers and ranSaw the metrics start/stop as expected.