HDDS-14685. Create context for BucketOperationHandler#9798
Merged
adoroszlai merged 3 commits intoapache:masterfrom Feb 22, 2026
Merged
HDDS-14685. Create context for BucketOperationHandler#9798adoroszlai merged 3 commits intoapache:masterfrom
adoroszlai merged 3 commits intoapache:masterfrom
Conversation
ivandika3
approved these changes
Feb 22, 2026
Contributor
There was a problem hiding this comment.
Thanks @adoroszlai , overall LGTM +1. Left some nits which can be addressed in follow-ups.
I am wondering whether this chain of responsibility pattern can be easily reused when we want to reimplement S3G in Netty (HDDS-9820) in the future. For example, I can somewhat see similarities between Netty ChannelPipeline and ChannelHandler and the current chain of responsibility pattern.
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3RequestContext.java
Show resolved
Hide resolved
Comment on lines
80
to
82
| if (!shouldHandle()) { | ||
| return null; // Not responsible for this request | ||
| } |
Contributor
There was a problem hiding this comment.
Technically, the shouldHandle can be refactored out, since it is part of the chain of responsibility framework instead of the S3 handler implementation. This can be addressed in follow-ups.
Contributor
Author
|
Thanks @ivandika3, @yandrey321 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor refactoring around
BucketOperationHandlerbased on more recent implementation ofObjectOperationHandler.S3RequestContextas parent class ofObjectRequestContext.S3RequestContextand pass it toBucketOperationHandler.BucketOperationHandlerto be an abstract class to reduce duplication.https://issues.apache.org/jira/browse/HDDS-14685
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/22226388402