NUTCH-3110 Upgrade to Tika 3.2.3 #887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to shaded Tika packages 3.1.0.0 provided by Tim Allison. The shaded packages are required to avoid version conflicts when running in distributed mode caused by incompatible versions of the commons-io jar shipped with Hadoop and required by Tika, cf. NUTCH-2959.
Add "text/javascript" as MIME type supported by "parse-js". Note: fixes parse-js unit tests. Tika 3.1.0 identifies the Javascript test document as "text/javascript" instead of "application/javascript".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address NUTCH-3110 and in the process supersede #850.
Essentially it upgrades Apache Tika from the shaded artifacts to the official Tika 3.2.3 release, addressing compatibility issues and restoring full functionality. Some noteworthy proposals
HashMaptoLinkedHashMapinDOMContentUtils.javato preserve link insertion order while deduplicating.TestHtmlParser.javawhere Java's UTF-16 encoder was adding a second BOM.Boilerpipe support: Restored boilerpipe content extraction using the new
tika-handler-boilerpipemodule.Additionally a bunch of new tests will assist in future Tika upgrades
This PR needs diligent testing in distributed mode before we consider merging.