Skip to content

Comments

Use Runtime.version() where applicable and remove unreachable code#9213

Merged
mbien merged 1 commit intoapache:masterfrom
mbien:use-runtime-version
Feb 20, 2026
Merged

Use Runtime.version() where applicable and remove unreachable code#9213
mbien merged 1 commit intoapache:masterfrom
mbien:use-runtime-version

Conversation

@mbien
Copy link
Member

@mbien mbien commented Feb 18, 2026

  • replace reflective access with direct calls
  • replace java version parsing with Runtime.version()
  • remove dead code paths due to past JDK bumps
  • minor cleanup in touched files

got inspired by the discussion in #9181 and a few things in my stash

@mbien mbien added this to the NB30 milestone Feb 18, 2026
@mbien mbien added Code cleanup Label for cleanup done on the Netbeans IDE ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Feb 18, 2026
@mbien
Copy link
Member Author

mbien commented Feb 18, 2026

@haidubogdan this also removes some php code which shouldn't be reachable anymore.

@BradWalker
Copy link
Member

Good stuff!!

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be nice!

@mbien mbien removed the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Feb 20, 2026
 - replace reflective access with direct calls
 - replace java version parsing with Runtime.version()
 - remove dead code paths due to past JDK bumps
 - minor cleanup in touched files
@mbien mbien force-pushed the use-runtime-version branch from 6562015 to 8287f24 Compare February 20, 2026 05:33
@mbien
Copy link
Member Author

mbien commented Feb 20, 2026

made two little changes: First in GradleJavaCompatProblemsProvider to use Runtime.Version.parse() during java home version parsing and removed the now unused Bundle entries for the deleted WindowsJdk7WarningPanel.

planning to merge once green.

@mbien mbien merged commit 8da3d41 into apache:master Feb 20, 2026
77 of 78 checks passed
@haidubogdan
Copy link
Contributor

@mbien
Tested on php project with ftp client.
Seems good. No issues found.

@mbien
Copy link
Member Author

mbien commented Feb 22, 2026

@haidubogdan thanks a lot for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:all-tests [ci] enable all tests Code cleanup Label for cleanup done on the Netbeans IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants