Skip to content

Add PR Automation action#2105

Merged
slawekjaranowski merged 1 commit intoapache:masterfrom
slawekjaranowski:pr-automation
Feb 15, 2025
Merged

Add PR Automation action#2105
slawekjaranowski merged 1 commit intoapache:masterfrom
slawekjaranowski:pr-automation

Conversation

@slawekjaranowski
Copy link
Member

@gnodet
Copy link
Contributor

gnodet commented Feb 12, 2025

We currently have more than one milestone opened for master branch: the upcoming rc-3, but we also have 4.0.0-rc-4 , 4.1.0 and 4.x. What happens in this case ?

@slawekjaranowski
Copy link
Member Author

We currently have more than one milestone opened for master branch: the upcoming rc-3, but we also have 4.0.0-rc-4 , 4.1.0 and 4.x. What happens in this case ?

When we merg PR without milestone assigned automat will search milestone which has in description target branch name.
So we need at least milestones for each branch which we want to accept merges for.

If PR will has milestone assigned nothing will happen.

Brach to milestone assign example in:
https://github.com/apache/maven-clean-plugin/milestones

We can have more milestone which will be not used by automat.

@slawekjaranowski
Copy link
Member Author

I also added branch names to maven milestones https://github.com/apache/maven/milestones

@slawekjaranowski slawekjaranowski merged commit 8fac124 into apache:master Feb 15, 2025
13 checks passed
@slawekjaranowski slawekjaranowski deleted the pr-automation branch February 15, 2025 08:33
@github-actions github-actions bot added this to the 4.0.0-rc-3 milestone Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants