Fix gh-11740: Add missing null check in validateProfileId()#11741
Open
abhu85 wants to merge 1 commit intoapache:masterfrom
Open
Fix gh-11740: Add missing null check in validateProfileId()#11741abhu85 wants to merge 1 commit intoapache:masterfrom
abhu85 wants to merge 1 commit intoapache:masterfrom
Conversation
The validateProfileId() method was missing a null check before calling validProfileIds.contains(id). Since validProfileIds uses ConcurrentHashMap.newKeySet() which doesn't allow null keys, a null profile ID would cause a NullPointerException instead of a proper validation error. This makes validateProfileId() consistent with validateCoordinateId() which already has the null check. Fixes apache#11740 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e3980bd to
273ccc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing null check before
validProfileIds.contains(id)invalidateProfileId()to preventNullPointerExceptionand make it consistent withvalidateCoordinateId().Problem
In
impl/maven-impl/.../DefaultModelValidator.java, thevalidateProfileId()method callsvalidProfileIds.contains(id)without checking ifidis null first.Since
validProfileIdsusesConcurrentHashMap.newKeySet()which doesn't allow null keys, a null profile ID would cause aNullPointerExceptioninstead of a proper validation error message.Inconsistency in the same file:
Solution
Add the same null check pattern used in
validateCoordinateId():Test Plan
mvn spotless:apply- formatting verifiedmvn test -pl impl/maven-impl -Dtest=DefaultModelValidatorTest- all 76 tests passCompatibility
This is a backward-compatible fix. Null profile IDs will now be properly handled by
validateStringNotEmpty()instead of throwing NPE.Fixes #11740
🤖 Generated with Claude Code