Moved the Classification, misc, and basics to the Map_Reduce_Folder#544
Moved the Classification, misc, and basics to the Map_Reduce_Folder#544rawkintrevo merged 18 commits intoapache:mainfrom
Conversation
rawkintrevo
left a comment
rawkintrevo
left a comment
There was a problem hiding this comment.
Why do you need all of these new gems if you're just moving files?
|
Also, if you're moving the files don't you want to setup redirects? |
Those are just Documentation files like not the part of actual code of website... I'll redirect them when I'm gonna work with the actual website code. Documentation part's gonna stay in github only, so no need to redirect them as such |
Removed the extra Gems that I had added for my system
This is not accurate. They are markdown files that are rendered into the website. You might want to wait a minute before you do this |
|
The code here looks fine, but the rendered website is built from these markdown files. Maybe review https://jekyllrb.com/docs/ and |
|
I've updated the links and redirected them to the MapReduceFolder. Also, checked that every link is working, @rawkintrevo Do review and merge if everything's good. |
if you did this, did you forget to commit and push it? |
rawkintrevo
left a comment
rawkintrevo
left a comment
There was a problem hiding this comment.
The only change other than renaming files is an artifact from a local merge.
|
I see your commit @krishna-dave206 , and I don't know if you're ready for another review, but did you want to put redirects in now, or is it ready to review as is? |
|
The redirect links are working for all the files that I moved, so there aren't any dead links. You can review it and merge this one. |
|
You've changed links, but you haven't set up redirects. We can talk about this f2f. |
|
lgtm |
2 participants
No description provided.