API: Simplify sanitization of literals in predicates#15224
Merged
stevenzwu merged 1 commit intoapache:mainfrom Feb 3, 2026
Merged
API: Simplify sanitization of literals in predicates#15224stevenzwu merged 1 commit intoapache:mainfrom
stevenzwu merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
cc @stevenzwu |
stevenzwu
approved these changes
Feb 3, 2026
Contributor
|
thanks @Kontinuation for the improvement and @huaxingao @singhpk234 for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tiny refactoring stems from #14101, where we try to add support for spatial predicates and implement sanitization for them. The type of the term and literal should match with each other for unsanitized expressions, and it is also reasonable to sanitize the literal by knowing the type of the literal alone without knowing the type of the term.