Skip to content

API: Simplify sanitization of literals in predicates#15224

Merged
stevenzwu merged 1 commit intoapache:mainfrom
Kontinuation:simplify-expr-sanitize
Feb 3, 2026
Merged

API: Simplify sanitization of literals in predicates#15224
stevenzwu merged 1 commit intoapache:mainfrom
Kontinuation:simplify-expr-sanitize

Conversation

@Kontinuation
Copy link
Member

This tiny refactoring stems from #14101, where we try to add support for spatial predicates and implement sanitization for them. The type of the term and literal should match with each other for unsanitized expressions, and it is also reasonable to sanitize the literal by knowing the type of the literal alone without knowing the type of the term.

@github-actions github-actions bot added the API label Feb 3, 2026
@Kontinuation Kontinuation changed the title API: Simplify expression sanitization API: Simplify sanitization of literals in predicates Feb 3, 2026
@Kontinuation Kontinuation marked this pull request as ready for review February 3, 2026 08:49
Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxingao
Copy link
Contributor

cc @stevenzwu

Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well !

@stevenzwu stevenzwu merged commit 45d2ed0 into apache:main Feb 3, 2026
33 checks passed
@stevenzwu
Copy link
Contributor

thanks @Kontinuation for the improvement and @huaxingao @singhpk234 for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants