Skip to content

sync cibuildwheel test env with uv #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 10 commits into from
Jan 16, 2026
+7 −4
Merged

sync cibuildwheel test env with uv #2913

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c7d6ac3
fix quoting
kevinjqliu Jan 14, 2026
e9fd5c4
do we need sqlalchemy?
kevinjqliu Jan 14, 2026
01f5690
lets try uv
kevinjqliu Jan 14, 2026
070e536
include sqlalchemy in dev dep
kevinjqliu Jan 14, 2026
2d44374
update uv lock
kevinjqliu Jan 14, 2026
42f72a0
try uv sync
kevinjqliu Jan 14, 2026
b33abd6
uv run pytest
kevinjqliu Jan 14, 2026
f1409e1
relative path
kevinjqliu Jan 14, 2026
2be8927
--all-extras
kevinjqliu Jan 14, 2026
be10d20
Revert "--all-extras"
kevinjqliu Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pypi-build-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
# Install test dependencies from pyproject.toml dependency-groups
CIBW_BEFORE_TEST: "uv pip install --group dev"
CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
# Ignore tests for pypy since not all dependencies are compiled for it
# and would require a local rust build chain
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/svn-build-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1 pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
# Install test dependencies from pyproject.toml dependency-groups
CIBW_BEFORE_TEST: "uv pip install --group dev"
CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
# Ignore tests for pypy since not all dependencies are compiled for it
# and would require a local rust build chain
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ dev = [
"mypy-boto3-glue>=1.28.18",
"mypy-boto3-dynamodb>=1.28.18",
"pyarrow-stubs>=20.0.0.20251107", # Remove when pyarrow >= 23.0.0 https://github.com/apache/arrow/pull/47609
"sqlalchemy>=2.0.18,<3",
Copy link
Contributor

@Fokko Fokko Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that this is for the SqlCatalog. Wouldn't it be cleaner to see if we can remove those direct imports (probably in the conftest.py)?

Copy link
Contributor Author

@kevinjqliu kevinjqliu Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep it is for the SqlCatalog. Now that we have SqlCatalog in conftest.py, this is technically a new "dev dependency"

iceberg-python/tests/conftest.py

Lines 2965 to 2972 in 8e4d424

def _create_sql_catalog(name: str, warehouse: Path) -> SqlCatalog:
catalog = SqlCatalog(
name,
uri="sqlite:///:memory:",
warehouse=f"file://{warehouse}",
)
catalog.create_tables()
return catalog

Copy link
Contributor

@Fokko Fokko Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it isn't being used for this specific test:

CIBW_TEST_COMMAND: "uv run --directory {project} pytest tests/avro/test_decoder.py"

Copy link
Contributor

@Fokko Fokko Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the Cython parser is out, we can rip all this out :D

]
# for mkdocs
docs = [
Expand Down
Loading