feat: add restcatalog authentication api #479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
reviewed
Jan 13, 2026
| /// \param properties Configuration properties. | ||
| /// \return A session for initialization, or the catalog session by default. | ||
| virtual std::shared_ptr<AuthSession> InitSession( | ||
| HttpClient* init_client, |
Contributor
There was a problem hiding this comment.
why use raw pointer？🤔 use std::shared_ptr instead?
| /// \param shared_client A long-lived, shared HTTP client. | ||
| /// \param properties Configuration properties (merged with server config). | ||
| /// \return A session for catalog operations. | ||
| virtual std::shared_ptr<AuthSession> CatalogSession( |
Contributor
There was a problem hiding this comment.
I found these methods in java implementation may all throw exceptions, so return Result<...>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add restcatalog authentication api