HBASE-29878 Improve the Documentation UI#7722
HBASE-29878 Improve the Documentation UI#7722yuriipalam wants to merge 5 commits intoapache:masterfrom
Conversation
PDavid
left a comment
There was a problem hiding this comment.
Many thanks Yurii for this nice PR. What a changeset! I think it is a new record. 😃
Jaehui-Lee
left a comment
There was a problem hiding this comment.
The new docs look much more modern and polished. Great work!
| DocsPage as FumaDocsPage, | ||
| DocsTitle as FumaDocsTitle | ||
| } from "@/components/docs/layout/docs/page"; | ||
| import defaultMdxComponents from "fumadocs-ui/mdx"; |
There was a problem hiding this comment.
nit: A link icon appears on heading hover, but it's not clickable since it disappears when moving the cursor toward it. It might be better to just hide it.
There was a problem hiding this comment.
That's by the framework design. I think there is a UX reason behind this
|
Heya @yuriipalam can you try squishing down your commit history. I've seen Yetus have trouble when there's too many commits. But, I'm 90% sure that these failures were due to a transient failure in the github API... I've been seeing the fail unicorn a lot lately. Anyway, give that a try, hopefully at least the general check will run. Thank boss! |
357e4d8 to
19a03da
Compare
19a03da to
8a5a504
Compare
|
@ndimiduk thanks, done |
|
Can you please look into if these can be fixed? |
I looked and seems like at the moment they can't be. These are new and packages that rely on these packages didn't release a newer fix version yet. We should check in a few days. Nevertheless, we're not really affected by that. We just return static assets and do not accept any input from the user. Theoretically, we could have just put the whole website on CDN because it has no server behind. So no worries :) |
|
It seems even though you squashed your commits - now we don't have too many commits - Yetus PR build still fails - summary is not generated. Probably this is because of the very large change-set size. |
As discussed earlier here https://lists.apache.org/thread/0ojmobpnyk44lbghqxh2c231c3bm6t6t
I’m presenting the new documentation website. You can check this out here:
https://hbase-landing.vercel.app/docs/
What’s been done:
Thanks!