Remove jodd-wot from fields tests

[jamesfredley]

Summary

Removes the jodd-wot test dependency from grails-fields by replacing its only usage with direct Spock string assertions against the rendered field output.

Changes

Area	Change
grails-fields tests	Removed jodd.lagarto.dom.jerry.Jerry imports and helper usage in DefaultFieldTemplateSpec.
grails-fields dependencies	Removed org.jodd:jodd-wot from test dependencies.
Root properties	Removed the now-unused joddWotVersion property.

Verification

Check	Result
`rg -n "jodd	jodd-wot"`
./gradlew.bat :grails-fields:test --tests "grails.plugin.formfields.DefaultFieldTemplateSpec"	Passed.
./gradlew.bat :grails-fields:test	Passed.

Checklist

• Searched for jodd-wot / jodd references.
• Replaced test usage with plain Spock assertions.
• Removed unused dependency/version wiring.
• Verified affected module tests pass.

[Copilot]

Pull request overview

This PR removes the jodd-wot test dependency from the grails-fields module by replacing the prior DOM-parsing assertions in DefaultFieldTemplateSpec with direct string-based Spock assertions, and then cleaning up the related Gradle dependency and version property wiring.

Changes:

• Refactored DefaultFieldTemplateSpec to drop Jerry/jerry usage and assert against rendered output strings.
• Removed org.jodd:jodd-wot from grails-fields test dependencies.
• Removed the now-unused joddWotVersion property from gradle.properties.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
grails-fields/src/test/groovy/grails/plugin/formfields/DefaultFieldTemplateSpec.groovy	Removes Lagarto/Jerry usage and replaces DOM assertions with string assertions for default/invalid/required rendering.
grails-fields/build.gradle	Drops the jodd-wot test dependency block (and its excludes).
gradle.properties	Removes the unused joddWotVersion property.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.4835%. Comparing base (c317eef) to head (3b8b35f).
⚠️ Report is 264 commits behind head on 8.0.x.

Additional details and impacted files

@@                Coverage Diff                 @@
##                8.0.x     #15965        +/-   ##
==================================================
+ Coverage     49.5558%   51.4835%   +1.9277%     
- Complexity      16930      17777       +847     
==================================================
  Files            1999       2039        +40     
  Lines           93753      95586      +1833     
  Branches        16419      16591       +172     
==================================================
+ Hits            46460      49211      +2751     
+ Misses          40131      39064      -1067     
- Partials         7162       7311       +149     

see 238 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jdaugherty]

I'm not a fan of the string comparisons - they're fragile and brittle. Why are we not using a standard html parser?

[jamesfredley]

Fair point on the brittleness. Worth separating the goal from the assertion style:

The primary objective (pre-release review, Codebase 3 / hygiene quick-win) is to remove the jodd-wot dependency - jodd-wot 3.3.8 dates to 2012 and is effectively unmaintained, and it's a single testImplementation usage in grails-fields/build.gradle. Getting it off the dependency list is the win.

On how to replace the assertion, the review lists two options: "modern assertions" or "Jsoup or equivalent". The trade-off:

• String assertions (current PR): removes jodd-wot with zero new dependencies, but is more brittle as you note.
• Jsoup: robust HTML parsing, but re-adds a test dependency to replace the one we're removing.

I'm happy to switch these to Jsoup (org.jsoup:jsoup, testImplementation) if you'd rather have a real parser and consider the added test dep acceptable - that still achieves the jodd-wot removal, just trading one modern dep for one archived one. Which would you prefer: keep it dependency-free with tightened assertions, or move to Jsoup?

[jdaugherty]

I'm happy with Jsoup, it's a parser that's well understood. I think we need to parse these values though, especially with some of the refactoring we've talked about. Otherwise, the tests are too brittle.

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 3b8b35f
▶️ Tests: 16025 executed
⚪️ Checks: 59/59 completed

---

Learn more about TestLens at testlens.app.