Open
Conversation
vlada-dudr
changed the title
vlada-dudr
force-pushed
the
feature/support-fe-https
branch
from
9519b02 to
9b5f1ce
Compare
vlada-dudr
commented
Sep 25, 2024
| this.password = dorisOptions.getPassword(); | ||
| this.loadProps = executionOptions.getStreamLoadProp(); | ||
| this.labelGenerator = labelGenerator; | ||
| this.hostPort = dorisOptions.getFenodes(); |
Author
There was a problem hiding this comment.
This one seems particularly odd - isn't fenodes comma separated string? I did this. thoug, as it is later being prepended to UPLOAD_URL_PATTERN
Author
|
Ok, this is bit more massive, than I expected. Let me know, if you want me to change something. I also ask for some testing, my Doris knowledge is pretty limited, so I likely missed something |
vlada-dudr
force-pushed
the
feature/support-fe-https
branch
from
9b5f1ce to
0552130
Compare
vlada-dudr
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #493
Problem Summary:
Cannot use http FE
Checklist(Required)
Further comments
Remove all hardwired
http://from urls and added conditionalhttp://prefixing if no scheme was declared