PostgreSQL: Support PostgreSQL ANALYZE with optional table and column#2187
Merged
iffyio merged 3 commits intoapache:mainfrom Feb 6, 2026
Merged
PostgreSQL: Support PostgreSQL ANALYZE with optional table and column#2187iffyio merged 3 commits intoapache:mainfrom
iffyio merged 3 commits intoapache:mainfrom
Conversation
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
guan404ming
force-pushed
the
pg-analyze-columns
branch
from
116e992 to
c22ee02
Compare
iffyio
reviewed
Feb 6, 2026
| /// Supported syntax varies by dialect: | ||
| /// - Hive: `ANALYZE TABLE t [PARTITION (...)] COMPUTE STATISTICS [NOSCAN] [FOR COLUMNS [col1, ...]] [CACHE METADATA]` | ||
| /// - PostgreSQL: `ANALYZE [VERBOSE] [t [(col1, ...)]]` | ||
| /// - General: `ANALYZE [TABLE] t` |
Contributor
There was a problem hiding this comment.
Can we add a link to the postgres docs describing the syntax? maybe this one https://www.postgresql.org/docs/current/sql-analyze.html
Member
Author
There was a problem hiding this comment.
Nice suggestion, just updated. Thanks!
Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
iffyio
approved these changes
Feb 6, 2026
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @guan404ming!
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ANALYZE, ANALYZE t, and ANALYZE t (col1, col2) all failed because parse_analyze() unconditionally required a table name and didn't handle the PostgreSQL parenthesized column syntax.
How
Made table_name optional (Option) in the Analyze struct and added column list parsing after the table name. Updated Display and Spanned to match.