docs: add SAFETY comments to all unsafe blocks in shuffle spark_unsafe module#3603
Merged
andygrove merged 1 commit intoapache:mainfrom Feb 26, 2026
Merged
Conversation
…e module Document the safety invariants for all 25 existing unsafe blocks across row.rs, list.rs, and map.rs. Also add a Safety section to the SparkUnsafeObject trait documenting the requirements for implementors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
// SAFETY:comments to all 25 existingunsafeblocks in thespark_unsafeshuffle module (row.rs,list.rs,map.rs)# Safetydocumentation section to theSparkUnsafeObjecttrait documenting invariants for implementorsAll unsafe in this module falls into one category: reading/writing JVM-allocated Spark
UnsafeRow/UnsafeArray/UnsafeMapmemory via raw pointers received through JNI. The safety invariants are:UnsafeRow/UnsafeArrayformatTest plan
cargo checkpasses🤖 Generated with Claude Code