fix: insert overwrite directory native writer#3531
Open
Shekharrajak wants to merge 3 commits intoapache:mainfrom
Open
fix: insert overwrite directory native writer#3531Shekharrajak wants to merge 3 commits intoapache:mainfrom
Shekharrajak wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2957
Rationale for this change
source operators like RangeExec (from spark.range()) produce InternalRow format, not Arrow format. The native writer requires Arrow-formatted input (requiresNativeChildren = true), so the conversion fails.
What changes are included in this PR?
Previously, users had to manually enable spark.comet.sparkToColumnar.enabled=true to convert RangeExec to Arrow format. This fix automates this conversion when native write is requested, making INSERT OVERWRITE DIRECTORY work out of the box without additional configuration.
How are these changes tested?
Unit tests : basic with RangeExec source , aggregation, compression