Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9074 +/- ##
============================================
+ Coverage 18.02% 18.05% +0.02%
- Complexity 16460 16654 +194
============================================
Files 5968 6024 +56
Lines 537213 542009 +4796
Branches 65975 66393 +418
============================================
+ Hits 96825 97842 +1017
- Misses 429469 433159 +3690
- Partials 10919 11008 +89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
BryanMLima
force-pushed
the
refactor-allocate-to-method
branch
from
1ff8f4a to
42d16d9
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
BryanMLima
force-pushed
the
refactor-allocate-to-method
branch
from
537c10f to
952c273
Compare
BryanMLima
changed the title
BryanMLima
changed the title
BryanMLima
requested review from
DaanHoogland and
JoaoJandre
and removed request for
JoaoJandre
JoaoJandre
left a comment
JoaoJandre
left a comment
There was a problem hiding this comment.
LGTM, I did some basic testing, changed the allocator to FirstFit and created some VMs, the VM allocation worked fine with and without tags. However, my tests were limited, further testing would be good.
BryanMLima
force-pushed
the
refactor-allocate-to-method
branch
2 times, most recently
from
dd1eb14 to
952c273
Compare
BryanMLima
force-pushed
the
refactor-allocate-to-method
branch
from
952c273 to
b7cc66f
Compare
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10801 |
|
@blueorangutan LLtest |
|
[SF] Trillian test result (tid-14448)
|
|
move to v23 @winterhazel @JoaoJandre ? |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17277 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-15760)
|
|
@winterhazel , is further testing needed on this? |
@DaanHoogland yes, it would be good to have some basic manual testing with the two affected allocators ( |
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17525 |
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17537 |
winterhazel
left a comment
winterhazel
left a comment
There was a problem hiding this comment.
I went through the code again, and confirmed that it still looks good over 4.23. There was a mistake in the GPU-enabled host prioritization logic of the FirstFitAllocator which I fixed in the latest commits.
Also, I've done some testing with the FirstFit and Random allocators using distinct (i) host, template, and service offering tags (including tag rules) combinations, (ii) guest OS rules, and (iii) CPU and memory available on the hosts. I did not test the HVM and GPU filters/priorization, but the refactored code seems to have the same logic, and there's a good amount of unit tests for it.
@DaanHoogland I think that we can merge this one with regression tests. Could you run the CI one last time?
winterhazel
added
status:waiting-for-smoketest-results
and removed
status:testing
labels
8 participants
Description
This PR refactors some
*Allocatorclasses, improving modularity and code legibility. This PR also made some changes to logs across these classes.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
I tested the allocation process in my personal lab, using both the
RandomAllocatorandFirstFitAllocatorallocators. I tried some variation of tags and offerings, and everything looks good. Furthermore, I also added a lot of unit tests for the methods that I refactored.How did you try to break this feature and the system with this change?