SPARKC-712: Update metrics for read and writes via DSV2#1369
Open
siadat wants to merge 5 commits into
Open
Conversation
siadat
marked this pull request as ready for review
September 2, 2024 10:19
Author
|
Hi @jacek-lewandowski Sorry for tagging, I was wondering if I could get your review on this PR. Thanks. |
Comment on lines
+1
to
+5
| /* | ||
| * Copyright DataStax, Inc. | ||
| * | ||
| * Please see the included license file for details. | ||
| */ |
Member
There was a problem hiding this comment.
this now needs to be the Apache License header, like other files.
Author
There was a problem hiding this comment.
Thanks for the review. I updated the header. Also rebased the branch.
Member
|
The GHA checks didn't run… guessing we have a failure in |
Thanks @ymuzammil for fixing the issue with the read metrics. Fixes SPARKC-712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How did the Spark Cassandra Connector Work or Not Work Before this Patch
Metrics are not updated for read and writes performed via DSV2. The values returned are all 0s.
General Design of the patch
InputMetricsUpdater and OutputMetricsUpdater are used in the DSV2 read (including joins and counts) and write paths.
Fixes: SPARKC-712
How Has This Been Tested?
A couple of integration tests were added.
Checklist: