[CALCITE-7398] Incorrect int cast in VariantNonNull#cast for BIGINT #4771
Conversation
| "INTEGER ARRAY"); | ||
| f.checkScalar("cast(cast('abc' as VARIANT) AS VARCHAR)", "abc", "VARCHAR"); | ||
| f.checkScalar("cast(cast('abc' as VARIANT) AS CHAR(3))", "abc", "CHAR(3)"); | ||
| f.checkScalar("cast(cast(2147483648 as VARIANT) as DECIMAL)", "2147483648", "DECIMAL(19, 0)"); |
There was a problem hiding this comment.
I think the bug fix way is OK，but please note:
- Your commit message should not contain words like "Fix," and you need to modify the Jira link content to match the PR.
- It is recommended to add the corresponding JIRA info to the
testCastToBooleanmethod, or you can add the corresponding comment here.
|
@qianheng-aws thanks for the patch. Per our contributing guidelines, when fixing an issue, the Jira/PR title (and the commit message) should describe the problem (and not begin with "Fix ..."), e.g. |
qianheng-aws
changed the title
Signed-off-by: Heng Qian <qianheng@amazon.com>
xuzifu666
left a comment
xuzifu666
left a comment
There was a problem hiding this comment.
I think the fix is acceptable.
I've encountered this CI error a few times before; it's sporadic and keeps recurring even after multiple reruns. I've documented it on a JIRA: https://issues.apache.org/jira/browse/CALCITE-7399.
This PR has minor changes; if you don't mind, you could resubmit a new pr to make CI happy.
|
I don't think we need to submit a new PR. This CI error doesn't seem to be related to the PR, so we can merge it in without worry. |
xuzifu666
added
the
LGTM-will-merge-soon
The CI error is indeed unrelated to changes. If there are no other comments in 24 hours, it will be merged. |
4 participants
CALCITE-7398