Skip to content

ATLAS-5042: [React UI] Entity detail page - UI alignment, styling, an… #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawarprasad123 merged 1 commit into from
May 29, 2025
Merged

ATLAS-5042: [React UI] Entity detail page - UI alignment, styling, an… #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions dashboard/src/components/Forms/FormTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,6 @@ const FormTextArea = ({ data, control }: any) => {
</LightTooltip>
</div>
<div className="w-100">
{/* <TextArea
maxRows={4}
aria-label="maximum height"
placeholder={name}
onChange={onChange}
minRows={2}
className="form-textfield form-textarea-field"
value={value}
/> */}
<textarea
placeholder={name}
onChange={onChange}
Expand Down
2 changes: 1 addition & 1 deletion dashboard/src/components/commonComponents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export const ExtractObject = (props: any) => {
}}
style={{
width: "unset !important",
whiteSpace: "nowrap",
whiteSpace: "normal",
color: deleteIcon ? "#bb5838" : "#4a90e2"
}}
>
Expand Down
4 changes: 4 additions & 0 deletions dashboard/src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,7 @@ textarea {
.hide {
display: none !important;
}

textarea::placeholder {
opacity: 0.7;
}
7 changes: 7 additions & 0 deletions dashboard/src/styles/formFields.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@
width: 100%;
flex: 1;
margin-bottom: 0.5rem !important;
height: 34px;
border-radius: 3px;
outline: none;
border: 1px solid rgba(0, 0, 0, 0.12);
padding: 6px 12px;
min-height: 34px;
width: 100%;
}

.form-textfield-label {
Expand Down
1 change: 1 addition & 0 deletions dashboard/src/styles/propertiesTab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,5 @@

.attribute-value-text > a {
width: 100% !important;
word-break: break-all;
}
1 change: 1 addition & 0 deletions dashboard/src/styles/relationshipLineage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,6 @@
.value-text {
a {
width: 100% !important;
word-break: break-all;
}
}
15 changes: 1 addition & 14 deletions dashboard/src/views/Classification/ClassificationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,22 +320,9 @@ const ClassificationForm = ({
/>
</div>
) : (
// <TextArea
// {...field}
// minRows={4}
// placeholder={"Description required"}
// value={sanitizeHtmlContent(descriptionValue)}
// onChange={(e) => {
// e.stopPropagation();
// const value = e.target.value;
// field.onChange(value);
// setValue("description", value);
// }}
// style={{ width: "100%" }}
// />

<textarea
{...field}
className="form-textarea-field"
placeholder={"Long Description"}
value={sanitizeHtmlContent(descriptionValue)}
onChange={(e) => {
Expand Down
11 changes: 0 additions & 11 deletions dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,17 +353,6 @@ const UserDefinedProperties = ({ loading, customAttributes, entity }: any) => {
<>
<div style={{ flex: "1" }}>
<textarea
style={{
height: "34px",
borderRadius: "3px",
outline: "none",
border: "1px solid rgba(0,0,0,0.12)",
padding: "6px 12px",
minHeight: "34px",
width: "100%",
marginTop: "8px !important",
marginBottom: "8px !important"
}}
maxRows={3}
rows={1}
aria-label="maximum height"
Expand Down
13 changes: 1 addition & 12 deletions dashboard/src/views/Glossary/GlossaryForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,20 +153,9 @@ const GlossaryForm = (props: {
/>
</div>
) : (
// <TextArea
// {...field}
// minRows={4}
// placeholder={"Long Description"}
// onChange={(e) => {
// e.stopPropagation();
// const value = e.target.value;
// field.onChange(value);
// setValue("description", value);
// }}
// style={{ width: "100%" }}
// />
<textarea
{...field}
className="form-textarea-field"
placeholder={"Long Description"}
onChange={(e) => {
e.stopPropagation();
Expand Down