Support GenericListViewArray::new_unchecked and refactor ListView json decoder#9648
Open
liamzwbao wants to merge 3 commits intoapache:mainfrom
Open
Support GenericListViewArray::new_unchecked and refactor ListView json decoder#9648liamzwbao wants to merge 3 commits intoapache:mainfrom
GenericListViewArray::new_unchecked and refactor ListView json decoder#9648liamzwbao wants to merge 3 commits intoapache:mainfrom
Conversation
liamzwbao
changed the title
GenericListViewArray::new_unchecked and refactor ListView json decoder
liamzwbao
changed the title
GenericListViewArray::new_unchecked and refactor ListView json decoderGenericListViewArray::new_unchecked and refactor ListView json decoder
liamzwbao
force-pushed
the
issue-9646-unsafe-list-view-json-reader
branch
from
3b662b4 to
519efa9
Compare
liamzwbao
force-pushed
the
issue-9646-unsafe-list-view-json-reader
branch
from
519efa9 to
5a9d088
Compare
alamb
approved these changes
Apr 14, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great to me -- thank you @liamzwbao
I left a small suggestion on comments, but I don't think it is necessary
| /// | ||
| /// # Safety | ||
| /// | ||
| /// Safe if [`Self::new`] would not panic with the given arguments |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Safe if [`Self::new`] would not panic with the given arguments | |
| /// The parts must be a valid ListViewArray according to the Arrow spec. | |
| /// See [`Self::try_new`] for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GenericListViewArray::new_uncheckedand refactor ListView json decoder #9646.Rationale for this change
What changes are included in this PR?
Support
GenericListViewArray::new_uncheckedand refactor ListView json decoder. Stacked on #9497, benchmark added in #9647Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No