refactor(validation): remove unused zOneOf helper#3339
Open
Jaswanth-arjun wants to merge 3 commits intoapache:masterfrom
Open
refactor(validation): remove unused zOneOf helper#3339Jaswanth-arjun wants to merge 3 commits intoapache:masterfrom
Jaswanth-arjun wants to merge 3 commits intoapache:masterfrom
Conversation
Adds a confirmation modal before deleting a plugin from forms to prevent accidental data loss and align with existing dashboard UX patterns.
Contributor
|
Your edits go beyond the scope you claimed. Please check and remove any unnecessary parts. |
Author
|
Thanks for the review. @bzp2010 I re-checked current master and confirmed that zOneOf is no longer present in src/utils/zod.ts (only zGetDefault is exported), and there are no call sites for zOneOf in the codebase. So this report is outdated on current master and not actionable as a behavior fix now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
zOneOf helper was reported to have incorrect behavior, but it is not used anywhere in the codebase.
Solution
Removed the unused helper function from src/utils/zod.ts.
Result
Improves code maintainability and removes dead code.