fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible#3336
fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible#3336Jaswanth-arjun wants to merge 1 commit intoapache:masterfrom
Conversation
Jaswanth-arjun
left a comment
There was a problem hiding this comment.
Hi, I’ve implemented a fix for this issue by replacing the fixed height layout with a responsive flex-based structure and making the action buttons sticky.
Please review my PR.
|
Hi @Jaswanth-arjun, please start by creating an issue describing your problem. If it's a UI issue, please include a screenshot. |
|
Hi @Baoyuantop i submitted solution by PR not creating issue. |
|
Hi @Jaswanth-arjun, when you encounter a problem, please check if an issue already describes it. If not, you will need to create one yourself. Please do not submit a pull request (PR) that is not associated with any issue. |
|
hoo @Baoyuantop i am sorry i am begginner i dont know really how to contribute i am taking guidence from chatgpt ,the steps it telling i am falowing ,it told me to find apropriate issue i found it and i fixed the bug with my knowledge later i asked chatgpt what should i do next it told me to do PR to respective issue thats it i done. |
|
Hi @Jaswanth-arjun, please update the description of your PR to include the issue number it resolves. |
|
Yeah @Baoyuantop i updated now could you please review my PR now.. |
Problem
Closes #3335
The PluginEditorDrawer used a fixed editor height which caused overflow issues.
On smaller or medium-height screens, the Monaco editor pushed the Add/Save
actions outside the visible area, making them difficult to access.
Solution
Removed fixed height from the editor
Introduced a flex-based column layout
Made the content area scrollable
Added a sticky footer to keep Add/Save actions always visible
Result
Add/Save buttons are always accessible
Layout adapts correctly to different screen sizes
Improved usability when editing large plugin configurations
Scope
Changes are limited to PluginEditorDrawer layout
No changes to API or business logic