refactor: improve type hints and error handling in Databricks providers#56845
Closed
josix wants to merge 3 commits intoapache:mainfrom
Closed
refactor: improve type hints and error handling in Databricks providers#56845josix wants to merge 3 commits intoapache:mainfrom
josix wants to merge 3 commits intoapache:mainfrom
Conversation
potiuk
reviewed
Oct 19, 2025
| if TYPE_CHECKING: | ||
| from airflow.models import Connection | ||
|
|
||
| class DatabricksConnectionT(Connection): |
Member
There was a problem hiding this comment.
I don't think we should use specific Databricks Connection here? I think we should anyhow going to import Connection from lazy-compat which has just been added in common.compat.
josix
force-pushed
the
gh-56738/fix-type-errors-providers/databricks
branch
2 times, most recently
from
7c14f9f to
963aae2
Compare
uranusjr
reviewed
Oct 29, 2025
Comment on lines
+151
to
+153
| dag_run = session.query(DagRun).filter(DagRun.dag_id == dag.dag_id, DagRun.run_id == run_id).first() | ||
| if not dag_run: | ||
| raise AirflowException("DagRun not found.") |
Member
There was a problem hiding this comment.
This combination should be unique so let’s just use one() here and let SQLAlchemy report any exceptions for us.
josix
force-pushed
the
gh-56738/fix-type-errors-providers/databricks
branch
from
963aae2 to
3a20957
Compare
josix
force-pushed
the
gh-56738/fix-type-errors-providers/databricks
branch
from
1fb9c57 to
7f88428
Compare
Contributor
Author
Contributor
Author
|
closed as #57768 has resolved the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #56738
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.