Make it possible to encode ArrayBuffer data.#10
Closed
nashby wants to merge 1 commit intoanycable:masterfrom
Closed
Make it possible to encode ArrayBuffer data.#10nashby wants to merge 1 commit intoanycable:masterfrom
nashby wants to merge 1 commit intoanycable:masterfrom
Conversation
Member
|
We already have this conversion at the transport layer: anycable-client/packages/core/websocket/index.js Lines 93 to 95 in 1ec7cc4 How do you setup the client? |
Author
|
Oh I see. I'm using this demo anycable/anycable_rails_demo#21 Given the link you posted it's strange that it doesn't work. I'll double check |
Member
This PR uses an older version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was working on this I discovered that protobuf data is received as
ArrayBufferwhich is not supported by protobuf.js (more info here)