Skip to content

Make it possible to encode ArrayBuffer data.#10

Closed
nashby wants to merge 1 commit intoanycable:masterfrom
nashby:array-buffer-support
Closed

Make it possible to encode ArrayBuffer data.#10
nashby wants to merge 1 commit intoanycable:masterfrom
nashby:array-buffer-support

Conversation

@nashby
Copy link
Copy Markdown

@nashby nashby commented Nov 19, 2021

While I was working on this I discovered that protobuf data is received as ArrayBuffer which is not supported by protobuf.js (more info here)

@palkan
Copy link
Copy Markdown
Member

palkan commented Nov 24, 2021

We already have this conversion at the transport layer:

if (this.format === 'binary') {
data = new Uint8Array(data)
}

How do you setup the client?

@nashby
Copy link
Copy Markdown
Author

nashby commented Nov 24, 2021

Oh I see. I'm using this demo anycable/anycable_rails_demo#21 Given the link you posted it's strange that it doesn't work. I'll double check

@palkan
Copy link
Copy Markdown
Member

palkan commented Nov 24, 2021

I'm using this demo anycable/anycable_rails_demo#21

This PR uses an older version of anycable-client libs; try upgrading.

@nashby nashby closed this Nov 27, 2021
@nashby nashby deleted the array-buffer-support branch November 27, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants