Skip to content

support nsh encap and decap#35

Open
zhenglinan wants to merge 3 commits into
antrea-io:mainfrom
zhenglinan:main
Open

support nsh encap and decap#35
zhenglinan wants to merge 3 commits into
antrea-io:mainfrom
zhenglinan:main

Conversation

@zhenglinan

Copy link
Copy Markdown

support nsh encap and decap
@tnqn
Signed-off-by: zhenglinan zhenglinan101@163.com

Signed-off-by: zhenglinan <zhenglinan101@163.com>
@tnqn tnqn requested a review from wenyingd August 15, 2022 14:51
@tnqn

tnqn commented Aug 15, 2022

Copy link
Copy Markdown
Member

@zhenglinan thanks for the PR.
@wenyingd could you take a look?

Comment thread ofctrl/ofAction.go Outdated
type NXEncapsulate struct {
HeaderSize uint16
HeaderType uint32
Property []openflow15.PropTLV

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename as Properties?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread ofctrl/ofAction.go
ActTypeSetField = "setField"
ActTypeCopyField = "copyField"
ActTypeMeter = "meter"
ActTypeEncapsulate = "encap"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar question on the name to this one antrea-io/libOpenflow#25 (comment)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not only for nsh,it is for ethernet、nsh、mpls and mplstc

@wenyingd

Copy link
Copy Markdown

Please update file VERSION, and go.mod/go.sum to import the changes in libOpenflow.

Signed-off-by: zhenglinan <zhenglinan101@163.com>
Signed-off-by: zhenglinan <zhenglinan101@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants