Added support for displayed chains icons based on ethereum-lists/chains#44
Open
morsela wants to merge 4 commits intoantonnell:mainfrom
Open
Added support for displayed chains icons based on ethereum-lists/chains#44morsela wants to merge 4 commits intoantonnell:mainfrom
morsela wants to merge 4 commits intoantonnell:mainfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/antonnell/networklist-org/GBg4Mgr4yayZ7zreR7AnzHr5X7no |
BertsLifee
approved these changes
Feb 4, 2022
BertsLifee
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ethereum-lists/chains provides as part of its data an ever-growing list of the chains icons.
All of those icons are hosted via IPFS, so this pull request introduces a simple
Iconcomponent that support ipfs source as well as regular "web2" source.Note that the number of source icons is not huge at the moment (~20)
Test Plan
run the site, went through a few examples out of the icons list, verifying they are displayed well, and that there are no regressions with the default icons for chains with no icons.