Incorporated Support for wallet_switchEthereumChain#43
Open
morsela wants to merge 2 commits intoantonnell:mainfrom
Open
Incorporated Support for wallet_switchEthereumChain#43morsela wants to merge 2 commits intoantonnell:mainfrom
morsela wants to merge 2 commits intoantonnell:mainfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/antonnell/networklist-org/H5hYEgTeHWWDzbmt676yuihZGKth |
EmtMeshal
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EIP-3326 introduced the ability to switch between existing networks, including default ones.
This PR introduces this new feature by trying to switch to an existing network, if it exists, before resolving to add the network (the recommended method according to metamask - see https://docs.metamask.io/guide/rpc-api.html#other-rpc-methods).
ref #38 and #35
Test Plan
Built the app, connected Metamask and tested successfully transitioning to multiple Ethereum test networks (Ropsten, Rinkeby) as well as adding new networks (e.g Expanse Network)