chore: merge main to feature#1681
Conversation
* docs: site * docs: site * docs: site * docs: gpt-vis
* feat(cursor): enhance useCursor hook to handle skillKey in node info * test(cursor): add cases for handling cursor position based on selection context * fix: sender --------- Co-authored-by: Mickey <951203214@qq.com>
Signed-off-by: Every <30380663+hongxuWei@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Summary of ChangesHello @kimteayon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user experience for dynamic content rendering and improving the precision of cursor management within editable components. It refines how streaming data is presented in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces streaming functionality to the gpt-vis component, enhancing the user experience by progressively rendering content and enabling automatic scrolling. The LineCompt component has been refactored for improved robustness, including better data parsing with error handling and adherence to web standards for custom attribute naming. Additionally, the useCursor hook has been extended with new logic to handle specific cursor positioning scenarios, such as when the startContainer is outside the editable area or a skillKey is detected, with corresponding test cases added to ensure correctness. A minor but important typo in the Chinese documentation was also corrected.
| style={{ whiteSpace: 'normal' }} | ||
| components={{ 'custom-line': LineCompt }} | ||
| paragraphTag="div" | ||
| streaming={{ hasNextChunk }} |
There was a problem hiding this comment.
Adding style={{ whiteSpace: 'normal' }} and paragraphTag="div" to XMarkdown provides better control over how the markdown content is rendered, especially for long lines and paragraph structure. This ensures consistent rendering of the streamed content.
<XMarkdown
style={{ whiteSpace: 'normal' }}
components={{ 'custom-line': LineCompt }}
paragraphTag="div"
streaming={{ hasNextChunk }}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #1681 +/- ##
===========================================
+ Coverage 97.36% 97.45% +0.09%
===========================================
Files 144 144
Lines 4705 4794 +89
Branches 1328 1374 +46
===========================================
+ Hits 4581 4672 +91
+ Misses 122 120 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Bundle ReportChanges will increase total bundle size by 1.51MB (80.67%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antdx-array-pushAssets Changed:
view changes for bundle: x-markdown-array-pushAssets Changed:
|
3 participants
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log