FIX: Release Desktop for lumped element example#555
Open
ramin4667 wants to merge 9 commits into
Open
Conversation
ramin4667
requested review from
Devin-Crawford,
SMoraisAnsys,
Samuelopez-ansys,
eblanco-ansys,
gmalinve and
maxcapodi78
as code owners
myoung301
reviewed
Mar 31, 2026
SMoraisAnsys
previously approved these changes
Apr 1, 2026
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just a minor comment as . shouldn't be in a section title.
github-actions
Bot
added
the
documentation
7 tasks
…lement_example' into fix/release_desktop_for_lumped_element_example
Comment on lines
-39
to
-45
|
|
||
| - repo: https://github.com/ansys/pre-commit-hooks | ||
| rev: v0.5.2 | ||
| hooks: | ||
| - id: add-license-headers | ||
| args: | ||
| - --start_year=2024 |
Collaborator
There was a problem hiding this comment.
Can you revert back this change ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the lumped element filter example by adding comments and the release desktop command to close the opened desktops.
Issue linked
Left the desktop open after the end of the example.
Checklist
Please complete the following checklist before submitting your pull request: