Conversation
Contributor
|
@bagratte Would setting |
lakrass
requested changes
Nov 27, 2025
Contributor
There was a problem hiding this comment.
Hey! I would suggest to change this PR to include the following changes:
- Set
vault_group: "vault"by default (not sure, why the group "bin" would make any sense) - Set
vault_manage_group: {{ false if (vault_install_hashi_repo) else true }}
With that, users still are abled to use a different group if desired and even can create it through this role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #329 but I'm not sure of the implications of this change.