feat(tui): add username and password options for basic authentication for TUI attach #8459
+50
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
It would be nice if environment variables were an option as well |
Contributor
Author
|
Nice Suggestion @rfhold , added in! |
Contributor
|
I think this pr solves the same underlying root issue: #9095 It is however scoped more narrow on fixing the authentication issue when username+password is set via an env var. It does not add new args to the cli for setting those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #8458
Allows for
usernameandpasswordoptions when attaching to a server.How did you verify your code works?
Tested it out by running an authed server and attaching to it passing the
--passwordand--usernameoptions.Screen.Recording.2026-01-14.at.15.08.06.mov