Skip to content

Conversation

@freon27
Copy link
Contributor

@freon27 freon27 commented Dec 2, 2025

I could not see any documentation regarding the 2nd parameter to the callbacks.

I tried it out and it worked but it would be good for it to be documented. Not sure if the examples need to fit to a specific pattern.

Copy link
Collaborator

@michael-small michael-small left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for adding this in.

Other than that one change to add those code backticks on 150, I think this is good to go.

Co-authored-by: michael-small <[email protected]>
@freon27 freon27 requested a review from michael-small December 3, 2025 20:01
@michael-small michael-small changed the title docs: document params argument docs: document mutations params argument Dec 3, 2025
@michael-small michael-small merged commit c574370 into angular-architects:main Dec 3, 2025
1 check passed
@michael-small
Copy link
Collaborator

Merged, thank you for this

@freon27 freon27 deleted the docs/improve-mutation-onsuccess-docs branch December 5, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants