feat(with-storage-sync): indexeddb support#129
feat(with-storage-sync): indexeddb support#129mzkmnk wants to merge 0 commit intoangular-architects:mainfrom
Conversation
df518ef to
df5449c
Compare
rainerhahnekamp
left a comment
There was a problem hiding this comment.
@mzkmnk looks good, but I initially meant that we integrate this into the existing withStorageSync. Like how withGlitchTracking or withDisabledNameIndices is done for withDevtools.
You will very likely have to adapt the code of withStorageSync to make this happen.
The reason for not bringing up a second storage syncer extension is that we can reuse parts of its code (like serialization)
|
@rainerhahnekamp |
Sure, if you have some work to delegate to me, let me know. |
|
@mzkmnk great work mate :) Thanks a lot. Hi @rainerhahnekamp can you please guide me how to use it and which version of the toolkit has this feature? Will it gonna be 19.0.3 ? Please let me know. Thanks in advance 🙏 |
|
@rainerhahnekamp |
b677206 to
03298f8
Compare
|
@mzkmnk big thanks for now. I will check the code asap and i do understand the potential necessity of async methods. |
653add5 to
607eb58
Compare
|
@rainerhahnekamp |
|
@mzkmnk Thanks for the update. Once you're ready for the review, let me know. Until then 👍good work |
@mzkmnk great work, eagerly waiting for it 👍 |
61b282d to
e3cd252
Compare
|
@rainerhahnekamp |
265654e to
bcfb642
Compare
bcfb642 to
ed7e28d
Compare
|
change PR #134 |
Issue
#111
Content
In this PR, we modified
withStorageSyncto support IndexedDB.Breaking Changes
storageargument ofwithStorageSynchas been renamed tostorageTypeand now accepts one of three strings:localStorage,sessionStorage, orindexedDB.indexedDBis selected as thestorageType, two new arguments,dbNameandstoreName, are added (wheredbNamerepresents the database name andstoreNameis analogous to a table name in a relational database).clearStorage,readFromStorage, andwriteToStorageare now treated as asynchronous.Sample Code