add DP to incoming and outgoing#18
Open
jobeland wants to merge 2 commits intoangshuman:add-dp-to-incoming-outgoingfrom
Open
add DP to incoming and outgoing#18jobeland wants to merge 2 commits intoangshuman:add-dp-to-incoming-outgoingfrom
jobeland wants to merge 2 commits intoangshuman:add-dp-to-incoming-outgoingfrom
Conversation
emgarten
reviewed
Dec 17, 2019
| var matched = source.Where(x => | ||
| { | ||
| IEnumerable<string> targets; | ||
| IDictionary<string, ISet<string>> targets; |
Collaborator
There was a problem hiding this comment.
nit: it would be better for perf to use Dictionary<string, HashSet<string>> for anything that isn't exposed externally
Collaborator
Author
There was a problem hiding this comment.
Got sidetracked. Thanks for the feedback, updated in b0701ad
Collaborator
|
This looks like a great improvement 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tracking for nodes already visited and nodes already matched when exploring the graph via outgoing/incoming constraints in aim to help reduce time and unnecessary calls to the store. At scale, this seemed to reduce calls to 1/3 (~300K to ~100K) and increased the memory footprint by ~200MB during calculation
PR is for a side branch for now and we can review later if we want to bring this into master