Open
Conversation
mborgerson
reviewed
Sep 22, 2025
| elif reader.header.e_flags & 0x400: | ||
| return archinfo.ArchARMHF("Iend_LE" if reader.little_endian else "Iend_BE") | ||
| elif reader.header.e_flags & EF_ARM_BE8: # ARM-BE8 has big endian data and little endian instructions | ||
| return archinfo.ArchARMEL("Iend_LE") |
Member
There was a problem hiding this comment.
ARM-BE8 has big endian data and little endian instructions
This change doesn't set memory endness?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM-BE8 is an architecture that has data in big endian and instructions in little endian, to support this it should be treated as little-endian.