Skip to content

Conversation

@alabiaga
Copy link
Member

…ountdown

Change-Id: Id4766a84292834a9a4ebe5364e804e356397ffa5

…ountdown

Change-Id: Id4766a84292834a9a4ebe5364e804e356397ffa5
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @alabiaga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the SnackbarNotificationManager to improve the user experience for live order updates. It introduces dynamic countdown timers for delivery and arrival notifications, leveraging the Chronometer feature, and adds brief, critical status texts to various notification stages. These changes align the sample application with the latest codelab guidelines, making the notification system more informative and engaging.

Highlights

  • Chronometer Countdown: Implemented chronometer-based countdowns for "Food Delivery" and "Food Arriving" notification states, providing users with real-time time remaining.
  • Short Critical Text: Added "setShortCriticalText" to various notification states ("Placing", "Prepping", "Arrived") to provide concise, critical information at a glance.
  • Codelab Synchronization: Updated the notification logic to match recent changes in the live update codelab, ensuring consistency and best practices.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the live update notification sample to use a chronometer for countdowns and adds short critical text to notifications. My review focuses on improving code clarity, correctness, and maintainability. I've identified several hardcoded strings that should be moved to resources for localization. I also found discrepancies and confusing calculations in the chronometer setup, where the code does not match the comments, and I've suggested using TimeUnit for better readability. Lastly, there's a minor formatting issue to address.

@alabiaga alabiaga merged commit 0484c49 into android:main Oct 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants