chore(units): use synthesized grype db rather than mock vuln provider#3276
Draft
willmurphyscode wants to merge 5 commits intomainfrom
Draft
chore(units): use synthesized grype db rather than mock vuln provider#3276willmurphyscode wants to merge 5 commits intomainfrom
willmurphyscode wants to merge 5 commits intomainfrom
Conversation
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Grype used a mock implementation of the vulnerability provider in its unit test, meaning that bugs in SQL queries, unexpected case sensitivity or insensitivity on queries or indexes, etc, might go undetected in the test suite and crop up at runtime.
This limitation was mostly due to the fact that there was no way to build a grype database because that code lived in grype-db. Now that the database builder's core code lives in this repo, we can build test databases to have better testing of matchers.
To address these issues: