fixed false positives for ubuntu kernel packages and backfixes #3129
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VE-2023-2163 Signed-off-by: Rez Moss <hi@rezmoss.com>
…VE-2023-2163 Signed-off-by: Rez Moss <hi@rezmoss.com>
rezmoss
force-pushed
the
false-post-ubuntu-ubuntu-backfixes
branch
from
21c89c3 to
40349fd
Compare
wagoodman
reviewed
Dec 23, 2025
| func (m *Matcher) Match(store vulnerability.Provider, p pkg.Package) ([]match.Match, []match.IgnoreFilter, error) { | ||
| // skip cpe matching for linux-kernel packages on major distros like ubuntu to avoid false positives from nvd's version ranges not covering backported fixes | ||
| // kernel vulns are still found accurately using dpkg/rpm matchers with distro data that includes backported fixes | ||
| if p.Type == syftPkg.LinuxKernelPkg && isMainDistro(p.Distro) { |
Contributor
There was a problem hiding this comment.
this is minor, however, since the first branch of this is by package type (kernel) we should make a separate matcher for this. This also keeps the stock matcher as simple as possible (and matchers are tailor made to handle by package type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip cpe matching for linux-kernel packages on major distros like ubuntu to avoid false positives from nvd's version ranges not covering backported fixes
kernel vulns are still found accurately using dpkg/rpm matchers with distro data that includes backported fixes
e.g CVE-2023-2163 for 5.15.0-164 ,fixed in 5.15.0-70.77~20.04.1