fix: update type hints to use LLMProvider instead of LLMClient#41
Merged
pragyan-amp merged 2 commits intomainfrom Nov 11, 2025
Merged
fix: update type hints to use LLMProvider instead of LLMClient#41pragyan-amp merged 2 commits intomainfrom
pragyan-amp merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes type errors where
LLMProviderinstances were being passed to functions that expectedLLMClienttype hints.Changes
stitch_tools.py: Changed type hints fromLLMClienttoLLMProviderin 3functions
pii_tools.py: Changed type hints fromLLMClienttoLLMProviderin 2functions
Context
The codebase was modernized to use
LLMProviderFactory.create()which returnsLLMProvider(Protocol), but helper functions still had type hints expecting the legacy
LLMClientclass.Testing